PolyTEOS10_bsq kernel issue blog post#184
Merged
michaeldenes merged 6 commits intomainfrom Aug 6, 2025
Merged
Conversation
Contributor
|
Once maths rendering is fixed in #185, the blog post will look like this 
|
erikvansebille
approved these changes
Aug 5, 2025
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Good blog post. See below some suggested changes; most importantly a Link to the actual bug fix PR
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
Member
Author
|
@VeckoTheGecko does it render nicely now? and @erikvansebille happy to merge? |
Member
|
Yep, I approved the post on the first round of review (assuming you indeed implemented my suggestions). So ready to merge, as far as I'm concerned |
VeckoTheGecko
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue with the
PolyTEOS10_bsqkernel has been identified, where incorrect values of seawater density were being computed. In this post, we explain the issue and how it may impact your simulations.